Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node.js Runtime stack #403

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Update Node.js Runtime stack #403

merged 1 commit into from
Jun 5, 2024

Conversation

azatsarynnyy
Copy link
Contributor

@azatsarynnyy azatsarynnyy commented May 23, 2024 •
edited
Loading

What does this PR do?:

Summarize the changes. Are any stacks or samples added or updated?

  • update schema to 2.2.2;
  • use https protocol for the nodejs devfile

Which issue(s) this PR fixes:

Link to github issue(s)
eclipse-che/che#22869

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

https://workspaces.openshift.com/#https://raw.githubusercontent.com/azatsarynnyy/registry/patch-1/stacks/nodejs/2.2.0/devfile.yaml

@azatsarynnyy azatsarynnyy requested review from BethGriggs and a team as code owners May 23, 2024 11:33
@openshift-ci openshift-ci bot requested review from michael-valdron and thepetk May 23, 2024 11:33
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 23, 2024

Hi @azatsarynnyy. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced May 23, 2024
Closed
Closed
thepetk
thepetk reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are bumping up the schema version of the devfile I'd bump up also the version of the stack.

@thepetk
Copy link
Contributor

thepetk commented May 23, 2024

/ok-to-test

@azatsarynnyy
Copy link
Contributor Author

As we are bumping up the schema version of the devfile I'd bump up also the version of the stack.

Done.
Thanks @thepetk and @ibuziuk for reviewing the PR!

thepetk
thepetk reviewed May 27, 2024
View reviewed changes
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! @BethGriggs as you are the owner of the stack could you please review the PR?

@openshift-ci openshift-ci bot added the lgtm Looks good to me label May 28, 2024
@thepetk
Copy link
Contributor

thepetk commented May 28, 2024

@devfile/che-team could you please review this PR?

svor
svor approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
screenshot-che-dogfooding apps che-dev x6e0 p1 openshiftapps com-2024 05 28-18_01_28

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: azatsarynnyy, BethGriggs, svor
Once this PR has been reviewed and has the lgtm label, please assign jdubrick for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Looks good to me label Jun 4, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 4, 2024

New changes are detected. LGTM label has been removed.

@thepetk
Copy link
Contributor

thepetk commented Jun 4, 2024

@BethGriggs @svor & @azatsarynnyy

once the tests pass I'll merge the PR

@michael-valdron
Copy link
Member

/retest

These failures doesn't look related to the changes.

@michael-valdron
Copy link
Member

/retest

These failures doesn't look related to the changes.

Need to try again later, there might be a problem with the CI environment right now.

@thepetk
Copy link
Contributor

thepetk commented Jun 4, 2024

/retest
These failures doesn't look related to the changes.

Need to try again later, there might be a problem with the CI environment right now.

@Jdubrick I feel is the same issue you're experiencing on #414 (comment)

@michael-valdron
Copy link
Member

Confirmed that there is issues with the image builder in the CI environment that is causing the current failures, waiting for further updates.

@michael-valdron
Copy link
Member

/retest

@thepetk thepetk merged commit d1e3f04 into devfile:main Jun 5, 2024
10 checks passed
@azatsarynnyy azatsarynnyy deleted the nodejs-update branch June 5, 2024 13:23
This was referenced Jun 5, 2024
Closed
Closed
@thepetk thepetk mentioned this pull request Jun 7, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thepetk thepetk thepetk left review comments

@ibuziuk ibuziuk ibuziuk left review comments

@BethGriggs BethGriggs BethGriggs approved these changes

@svor svor svor approved these changes

@michael-valdron michael-valdron Awaiting requested review from michael-valdron

Assignees

@svor svor

@BethGriggs BethGriggs

Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@azatsarynnyy @thepetk @michael-valdron @svor @ibuziuk @BethGriggs